Skip to content

SK-1829 Fix http status for validation errors in Java SDK v2 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skyflow-vivek merged 2 commits into from
Jan 16, 2025
Merged

SK-1829 Fix http status for validation errors in Java SDK v2 #154

skyflow-vivek merged 2 commits into from
Jan 16, 2025

Conversation

@skyflow-vivek
Copy link
Collaborator

@skyflow-vivek skyflow-vivek commented Jan 15, 2025 •
edited
Loading

This PR adds an enum for default Http status in validation errors thrown by Java SDK. It also fixes issues in invoke connection flow for outbound connections.

Why

  • Added default Http status for SDK side validation errors.
  • Fixed outbound connection flow for invoke connection.
  • Fixed error handling in invoke connection.

Goal

  • Will add default Http status for SDK side validation errors.
  • Will remove issues with invoke connection flow.
  • Will help in reducing inconsistencies and failures in E2E tests.

Testing

  • Fixed failing test cases due to this changes introduced.
  • Covered the newly added enum in unit tests.

@skyflow-vivek skyflow-vivek changed the base branch from v2 to release/25.1.1 January 16, 2025 13:55
@skyflow-vivek skyflow-vivek merged commit 27ca248 into release/25.1.1 Jan 16, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skyflow-shravan skyflow-shravan skyflow-shravan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skyflow-vivek @skyflow-shravan